t-vi commented on a change in pull request #5834:
URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442145084
##########
File path: python/tvm/relay/frontend/pytorch.py
##########
@@ -115,64 +115,70 @@ def inplace_add_to_add(op_name):
return False
+
# operator implementation
def _elemwise(name):
def _impl(inputs, input_types):
- # TODO: Figure out a better way to get typing to work for tensor +
scalar
- type0 = input_types[0]
- if isinstance(inputs[1], _expr.Expr):
- type0 = input_types[1]
-
- type1 = input_types[1]
- if isinstance(inputs[0], _expr.Expr):
- type1 = input_types[0]
-
- data0 = _convert_elemwise_input(inputs[0], type0)
- data1 = _convert_elemwise_input(inputs[1], type1)
-
+ data0, data1 = _pytorch_promote_types(inputs[:2], input_types[:2])
Review comment:
So I fixed the where, but I then get errors in other obscure corners
(that reach beyond the frontend/pytoch.py). Did the GPT2 model translate
correctly with the old code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
