t-vi commented on a change in pull request #5834:
URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442747459
##########
File path: python/tvm/relay/frontend/pytorch.py
##########
@@ -2120,14 +2146,17 @@ def _get_constant(node):
attr_name = attribute_names[0]
ty = node.output().type().kind()
- if ty in ["IntType", "BoolType"]:
+ if ty == "IntType":
Review comment:
I really wanted to cast bool(...) for bool types. Somehow that didn't
survive the refactors of the PR. Do you want me to merge the two or add the
cast? I tentatively added the cast.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
