mwillsey commented on a change in pull request #6011:
URL: https://github.com/apache/incubator-tvm/pull/6011#discussion_r457719724
##########
File path: rust/tvm-rt/src/to_boxed_fn.rs
##########
@@ -43,9 +43,8 @@ where
{
Review comment:
The whole `ToBoxedFn` seems a little strange. A trait called `To` should
have function that takes `Self`, not return `Self`. It seems to be implemented
backwards.
Could you instead just have a generic, inherent method on `Function`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
