ANSHUMAN87 commented on a change in pull request #6162:
URL: https://github.com/apache/incubator-tvm/pull/6162#discussion_r463430572
##########
File path: src/parser/parser.cc
##########
@@ -542,39 +496,60 @@ class Parser {
*/
template <typename T>
Array<T> ParseSequence(TokenType start, TokenType sep, TokenType stop,
std::function<T()> parse,
- std::function<void()> before_stop = nullptr) {
+ std::function<bool()> before_stop = nullptr) {
+ DLOG(INFO) << "Parser::ParseSequence: start=" << start << "sep=" << sep <<
"stop=" << stop;
Review comment:
Thanks! I am also in favor of more log info in TVM(more precisely
operational logs stage wise). But i had the notion that we will use the new
Diagnostic framework even for INFO as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
