mbrookhart commented on a change in pull request #6152: URL: https://github.com/apache/incubator-tvm/pull/6152#discussion_r464610109
########## File path: src/relay/transforms/to_basic_block_normal_form.cc ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * + * \file to_basic_block_normal_form.cc + * + * \brief Turn an expression to the basic normal form. + */ +#include <tvm/relay/analysis.h> +#include <tvm/relay/expr_functor.h> +#include <tvm/relay/transform.h> +#include <tvm/support/logging.h> + +#include "../../support/arena.h" +#include "../analysis/dependency_graph.h" +#include "let_list.h" +#include "pass_util.h" + +namespace tvm { +namespace relay { + +Expr ToBasicBlockNormalFormAux(const Expr& e) { Review comment: :) I missed this naming influence in the conversations @tqchen and I had a few months ago. Thanks! That makes things a lot clearer for me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
