jroesch commented on a change in pull request #6336:
URL: https://github.com/apache/incubator-tvm/pull/6336#discussion_r477122547
##########
File path: src/relay/transforms/gradient.cc
##########
@@ -438,12 +449,17 @@ Expr BPEmpty() {
struct ReverseAD : ExprMutator {
using ADVarMap = std::unordered_map<Var, Var, ObjectPtrHash, ObjectPtrEqual>;
-
+ using ADGVarMap = std::unordered_map<GlobalVar, GlobalVar, ObjectPtrHash,
ObjectPtrEqual>;
+ Optional<IRModule> mod;
Review comment:
Can you just add a note about this to your on-going doc on things we
might want to refactor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
