jtuyls commented on a change in pull request #6342:
URL: https://github.com/apache/incubator-tvm/pull/6342#discussion_r478283171
##########
File path: docker/Dockerfile.ci_cpu
##########
@@ -83,3 +83,7 @@ RUN bash /install/ubuntu_install_caffe.sh
# Github Arm(R) Ethos(TM)-N NPU driver
COPY install/ubuntu_install_ethosn_driver_stack.sh
/install/ubuntu_install_ethosn_driver_stack.sh
RUN bash /install/ubuntu_install_ethosn_driver_stack.sh
+
+# Vitis-AI PyXIR CI deps
+COPY install/ubuntu_install_vai_packages.sh
/install/ubuntu_install_vai_packages.sh
+RUN bash /install/ubuntu_install_vai_packages.sh
Review comment:
@leandron The ci_vai docker we added in the other PR is actually not
meant to be used for CI at the moment. It's the main docker we use in our flow
as you can see in our documentation:
https://github.com/apache/incubator-tvm/blob/8903b1a3251370ee1013fc2f9f3ef6004fa0e4b2/docs/deploy/vitis_ai.rst
and builds on top of the general Vitis-AI docker
(https://github.com/Xilinx/Vitis-AI) containing the necessary Vitis-AI tools
for quantization, compilation, etc.
Two questions:
- Should we rename the ci_vai to make it more clear that it's our main
docker environment and it's not really for CI at the moment?
- Should we add it to this PR even though it's not meant to be used for CI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
