FrozenGene commented on a change in pull request #6391:
URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483200130



##########
File path: python/tvm/auto_scheduler/measure.py
##########
@@ -657,9 +692,11 @@ def timed_func():
 
         if error_no == 0:
             try:
-                # TODO(FrozenGene): Update to ndarray.non-empty.
                 args = [ndarray.empty(get_const_tuple(x.shape), x.dtype, ctx) 
for x in
                         build_res.args]
+                random_fill = 
remote.get_function("tvm.contrib.random.random_fill")

Review comment:
       Yes, we could add one message. As `random fill` is the base if we want 
to get precise measure result, I would like to add one assert to make sure we 
have this function. Prompt users you should turn on `USE_RANDOM` and not just 
warning to make it pass. Does it make sense to you?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to