tmoreau89 commented on pull request #9: URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-687523850
Thanks again @remotego for addressing the comments. If we could address: (1) Adding a README file (ideally with instructions on how to compile / run on the FPGA) before we migrate this to official TVM documentation. (2) Using constants in the vta cost model (3) Adding comments to `MEM_ADDR_IDENTIFIER` initialization Then the PR is looking in good shape. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org