kevinthesun commented on a change in pull request #6422:
URL: https://github.com/apache/incubator-tvm/pull/6422#discussion_r485252800
##########
File path: include/tvm/topi/detail/broadcast.h
##########
@@ -51,8 +51,8 @@ inline BroadcastHelper BroadcastShape(const
tvm::Array<tvm::PrimExpr>& shape1,
int i;
for (i = 1; i <= std::min(s1_size, s2_size); ++i) {
// TODO(@icemelon9): Need to revisit this part
- const VarNode* var1 = shape1[s1_size - i].as<VarNode>();
- const VarNode* var2 = shape2[s2_size - i].as<VarNode>();
+ const IntImmNode* static_size1 = shape1[s1_size - i].as<IntImmNode>();
Review comment:
We need to check IntImm to include any symbolic expression type. Here
Any might not work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
