imalsogreg commented on a change in pull request #6401:
URL: https://github.com/apache/incubator-tvm/pull/6401#discussion_r485301592
##########
File path: rust/tvm-sys/build.rs
##########
@@ -19,22 +19,39 @@
extern crate bindgen;
+use std::env;
use std::path::PathBuf;
-use std::env;
+use anyhow::{Context, Result};
-fn main() {
+fn main() -> Result<()> {
let tvm_home = option_env!("TVM_HOME").map(str::to_string).unwrap_or({
Review comment:
(Not really related to `anyhow`)
`unwrap_or` will do the `CARGO_MANIFEST_DIR` work even if `TVM_HOME` is set
(because `unwrap_or` is strict). `.unwrap_or_else(|| { ... ` will skip that
work, if that's the desired behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
