[incubator-tvm] branch master updated: ROCm: use GcnArch for mcpu and ApiVersion to select code object version (#6447)

[masahi]

This is an automated email from the ASF dual-hosted git repository.

masahi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git


The following commit(s) were added to refs/heads/master by this push:
     new 01460e0  ROCm: use GcnArch for mcpu and ApiVersion to select code 
object version (#6447)
01460e0 is described below

commit 01460e0fd441cfaba3c800017c7801ed6433172c
Author: Thomas Viehmann <tv.c...@beamnet.de>
AuthorDate: Fri Sep 11 08:11:44 2020 +0200

    ROCm: use GcnArch for mcpu and ApiVersion to select code object version 
(#6447)
---
 src/target/target_kind.cc | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/src/target/target_kind.cc b/src/target/target_kind.cc
index efb9d16..8cb6786 100644
--- a/src/target/target_kind.cc
+++ b/src/target/target_kind.cc
@@ -172,19 +172,28 @@ Map<String, ObjectRef> UpdateROCmAttrs(Map<String, 
ObjectRef> attrs) {
     arch = ExtractIntWithPrefix(mcpu, "gfx");
     CHECK(arch != -1) << "ValueError: ROCm target gets an invalid GFX version: 
-mcpu=" << mcpu;
   } else {
-    TVMRetValue version;
-    if (!DetectDeviceFlag({kDLROCM, 0}, runtime::kApiVersion, &version)) {
-      LOG(WARNING) << "Unable to detect ROCm version, default to 
\"-mcpu=gfx305\" instead";
-      arch = 305;
+    TVMRetValue val;
+    if (!DetectDeviceFlag({kDLROCM, 0}, runtime::kGcnArch, &val)) {
+      LOG(WARNING) << "Unable to detect ROCm compute arch, default to 
\"-mcpu=gfx900\" instead";
+      arch = 900;
     } else {
-      arch = version.operator int();
+      arch = val.operator int();
     }
     attrs.Set("mcpu", String("gfx") + std::to_string(arch));
   }
   // Update -mattr before ROCm 3.5:
   //   Before ROCm 3.5 we needed code object v2, starting
   //   with 3.5 we need v3 (this argument disables v3)
-  if (arch < 305) {
+
+  TVMRetValue val;
+  int version;
+  if (!DetectDeviceFlag({kDLROCM, 0}, runtime::kApiVersion, &val)) {
+    LOG(WARNING) << "Unable to detect ROCm version, assuming >= 3.5";
+    version = 305;
+  } else {
+    version = val.operator int();
+  }
+  if (version < 305) {
     Array<String> mattr;
     if (attrs.count("mattr")) {
       mattr = Downcast<Array<String>>(attrs.at("mattr"));