[GitHub] [incubator-tvm] comaniac commented on pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

[GitBox]

comaniac commented on pull request #6655:
URL: https://github.com/apache/incubator-tvm/pull/6655#issuecomment-707867942


   This solution looks too ad hoc to me. From the semantic of the changes, I 
think this PR can be generalized to "improve the annotate target pass to 
annotate non-call ops to default". Accordingly, the API could be like
   
   ```python
   AnnotateTarget(targets, skip_non_call_ops=False)(mod) # I am bad at naming 
but it is the point
   ```
   
   cc @zhiics 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org