jroesch commented on a change in pull request #6656: URL: https://github.com/apache/incubator-tvm/pull/6656#discussion_r512318133
########## File path: cmake/modules/LLVM.cmake ########## @@ -16,7 +16,12 @@ # under the License. # LLVM rules -add_definitions(-DDMLC_USE_FOPEN64=0) +# Due to LLVM debug symbols you can sometimes face linking issues on +# certain compiler, platform combinations if you don't set NDEBUG. +# +# See https://github.com/imageworks/OpenShadingLanguage/issues/1069 +# for more discussion. +add_definitions(-DDMLC_USE_FOPEN64=0 -DNDEBUG=1) Review comment: LLVM doesn't link correctly if you don't read the issues. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
