tqchen commented on pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#issuecomment-731762607
I did a pass on the C++ side(didn't get a chance to look at c module) the main thing to pay attentions are: - NDArray's deleter handling, need to delete the container itself as well(besides the resources) - Get DLTensor repr does not need ToDLPack, instead, just use NDArray.operator-> Things to discuss: - the type switch that generate typed LLVM array can be quite long, and requires creation of a lot of LLVM objects. If we can use LLVM's target mechanism to know the endian of the target machine, perhaps it is better to do byteswaping by ourselves. Alternatively, we can simply only switch on bits, but not types. E.g. use uint32 for both float32, int32, and uint32 array. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
