ZihengJiang commented on a change in pull request #7084:
URL: https://github.com/apache/tvm/pull/7084#discussion_r544733728
##########
File path: src/tir/transforms/make_packed_api.cc
##########
@@ -41,6 +41,56 @@
namespace tvm {
namespace tir {
+class ReturnRewriter : public StmtMutator {
+ public:
+ explicit ReturnRewriter(Var ret_var, Var ret_tcode) : ret_var_(ret_var),
ret_tcode_(ret_tcode) {}
+
+ Stmt VisitStmt_(const EvaluateNode* node) override {
+ Stmt ret = StmtMutator::VisitStmt_(node);
+ const EvaluateNode* eval = ret.as<EvaluateNode>();
+ CHECK(eval);
+ if (const CallNode* call = eval->value.as<CallNode>()) {
+ if (call->op.same_as(builtin::ret())) {
+ CHECK_EQ(call->args.size(), 1);
Review comment:
Things like this is quite easy to understand by eyeball the error
throwing, I don't think error message is necessary for every place or would you
like to add error message for every place like here?
https://github.com/apache/tvm/blob/main/src/relay/op/nn/pad.cc#L58-L59
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
