giuseros commented on a change in pull request #7093:
URL: https://github.com/apache/tvm/pull/7093#discussion_r545685677
##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -1991,20 +1994,29 @@ def convert_conv(self, op, conv_type):
weight_tensor_type_str = self.get_tensor_type_str(weight_tensor_type)
in_expr = self.get_expr(input_tensor_idx)
- weight_value = self.get_tensor_value(weight_tensor)
-
- # TFLite kernel layout:
- # convolution:
- # OC KH KW IC, we require KH KW IC OC (HWIO)
- # depthwise convolution:
- # 1 KH KW C(input_c * depth_multiplier), we require
- # KH KW IC M (depth_multiplier) (HWOI)
- if is_depthwise_conv:
- weight_value = weight_value.reshape(kernel_h, kernel_w, input_c,
depth_multiplier)
+
+ if self.has_expr(weight_tensor.tensor_idx):
+ weight_expr = self.get_expr(weight_tensor.tensor_idx)
+ if is_depthwise_conv:
+ weight_expr = _op.reshape(
+ weight_expr, (kernel_h, kernel_w, input_c,
depth_multiplier)
+ )
+ else:
+ weight_expr = _op.transpose(weight_expr, axes=(1, 2, 3, 0))
Review comment:
Hi @euntaik , what I meant was to write it as comment into the code
(before the `if` statement). It is so that when people go through the code they
will know what is going on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
