masahi commented on a change in pull request #7210:
URL: https://github.com/apache/tvm/pull/7210#discussion_r557780399
##########
File path: src/relay/backend/compile_engine.cc
##########
@@ -593,8 +604,10 @@ class MakeShapeFunc : public
backend::MemoizedExprTranslator<Array<te::Tensor>>
std::unordered_map<Expr, Array<te::Tensor>, ObjectPtrHash, ObjectPtrEqual>
param_data_;
/*! \brief Map from parameter to list of shape placeholder */
std::unordered_map<Expr, Array<te::Tensor>, ObjectPtrHash, ObjectPtrEqual>
param_shapes_;
- /*! \brief Stack of data dependencies for shape function */
+ /*! \brief Stack of data dependencies for shape function, specified per op */
std::vector<bool> data_dependants_;
Review comment:
There is a usage of `data_dependants_` at
https://github.com/apache/tvm/blob/f658556d5f9491138fde4451baf60c9621d0755d/src/relay/backend/compile_engine.cc#L453
I didn't look into this in detail, can we replace this with
`data_dependants_per_input_`? To me it seems per-op data dependant makes more
sense here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
