altanh commented on a change in pull request #7287:
URL: https://github.com/apache/tvm/pull/7287#discussion_r560391942
##########
File path: python/tvm/topi/random/kernel.py
##########
@@ -234,6 +242,18 @@ def gen_ir(gen_ptr, out_gen_ptr, out_array_ptr):
out_gen = irb.buffer_ptr(out_gen_ptr)
out_array = irb.buffer_ptr(out_array_ptr)
+ # Check that unsigned arithmetic wraps, as it is required to implement
threefry correctly.
+ irb.emit(
Review comment:
echoing Tianqi's comment, will compilation fail on a target that doesn't
support `AssertStmt` but would in theory have everything needed for Threefry
PRNG?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
