masahi edited a comment on pull request #7441: URL: https://github.com/apache/tvm/pull/7441#issuecomment-780440200
For your first implementation, combination-based approach is ok. But `unique` is important enough that I think it deserves its own operator. Also implementation directly in ir builder will likely be faster. Supporting other options will also be easier if we write in ir builder. So use ir builder if you are comfortable with it, otherwise combination of relay ops is fine. Performance + support for options can be done later (by me). Don't worry about `unique_by_key`. Last time I checked the pytorch implementation, I concluded that we can do eveything pytorch does via ir builder. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
