tqchen commented on a change in pull request #7785:
URL: https://github.com/apache/tvm/pull/7785#discussion_r614865828



##########
File path: src/target/source/codegen_c_host.cc
##########
@@ -40,13 +40,16 @@ namespace codegen {
 
 CodeGenCHost::CodeGenCHost() { module_name_ = 
GetUniqueName("__tvm_module_ctx"); }
 
-void CodeGenCHost::Init(bool output_ssa, bool emit_asserts, std::string 
target_str) {
+void CodeGenCHost::Init(bool output_ssa, bool emit_asserts, bool 
is_aot_executor,
+                        std::string target_str) {

Review comment:
       to add on a bit on call_packed. We could introduce another series of 
`call_cpacked` intrinsics, which does not do string lookup. This way we do not 
need to infer the PackedFunc call variant in the flag(but directly reflect them 
in the IR)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to