areusch commented on a change in pull request #7867: URL: https://github.com/apache/tvm/pull/7867#discussion_r616187531
########## File path: src/runtime/opencl/opencl_device_api.cc ########## @@ -72,20 +75,26 @@ void OpenCLWorkspace::GetAttr(Device dev, DeviceAttrKind kind, TVMRetValue* rv) *rv = static_cast<int64_t>(value); break; } - case kComputeVersion: - return; - case kDeviceName: { - char value[128] = {0}; - OPENCL_CALL( - clGetDeviceInfo(devices[index], CL_DEVICE_NAME, sizeof(value) - 1, value, nullptr)); - *rv = std::string(value); + case kComputeVersion: { + std::string ret = GetDeviceInfo(devices[index], CL_DEVICE_VERSION); + // String returned is "OpenCL $MAJOR.$MINOR $VENDOR_INFO". To + // match other implementations, we want to return "$MAJOR.$MINOR" Review comment: er, I haven't tried this but what's checked-in at main looks like it returns `clGetDeviceInfo(..., CL_DEVICE_NAME, ...)` and this change strips any suffix past a `' '`. am I missing something here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org