masahi commented on a change in pull request #7883:
URL: https://github.com/apache/tvm/pull/7883#discussion_r616231499
##########
File path: python/tvm/topi/image/resize.py
##########
@@ -59,6 +59,33 @@ def get_2d_pixel(data, layout, boxes, image_height,
image_width, n, c, y, x, cc,
return data(n, c, y, x, cc).astype("float")
+def get_iny_inx(
+ y, x, image_height, image_width, target_height, target_width,
coordinate_transformation_mode
+):
+ scale_y = te.div(image_height.astype("float"),
target_height.astype("float"))
+ scale_x = te.div(image_width.astype("float"), target_width.astype("float"))
+ if coordinate_transformation_mode == "half_pixel":
+ in_y = (y + 0.5) * scale_y - 0.5
+ in_x = (x + 0.5) * scale_x - 0.5
+ elif coordinate_transformation_mode == "align_corners":
+ in_y = y * (image_height - 1).astype("float") / (target_height - 1)
+ in_x = x * (image_width - 1).astype("float") / (target_width - 1)
+ elif coordinate_transformation_mode == "asymmetric":
+ in_y = y * scale_y
+ in_x = x * scale_x
+ elif coordinate_transformation_mode == "pytorch_half_pixel":
Review comment:
Hmm I thought we were testing `half_pixel` in PT frontend but indeed it
doesn't seem so. I think `half_pixel` corresponds to `bilinear` +
`align_corners=False` but this combination is not there below
https://github.com/apache/tvm/blob/b24fbe7dee10195b6585634c0625828fe8624d5f/tests/python/frontend/pytorch/test_forward.py#L1701-L1703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
