giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-828639039
Hi @areusch , So, about solution 2) , it is also not affecting the logs, I think. Actually, it would be transparent to the logs because we are not touching the target. A major drawback of 1) is about `tvmc`. If we go for 1), the user needs to specify the executor directly in the target via `tvmc`. When we remove it from the target, also the `tvmc` command will have to change. With 2), we can have a flag in `tvmc`, e.g., `--executor` and this will translate to whatever `relay.build` command we decide. In general, why adding something to the target if we know we are going to remove it entirely from the target (and when it is so straightforward to express as a `relay.build` parameter)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org