manupa-arm commented on a change in pull request #7938:
URL: https://github.com/apache/tvm/pull/7938#discussion_r626849123



##########
File path: src/relay/backend/graph_executor_codegen.cc
##########
@@ -551,10 +713,14 @@ class GraphExecutorCodegen : public 
backend::MemoizedExprTranslator<std::vector<
   Map<Expr, Array<IntegerArray>> storage_device_map_;
   /*! \brief lowered funcs */
   std::unordered_map<std::string, IRModule> lowered_funcs_;
+  /*! \brief lowered funcs */
+  Map<String, FunctionInfo> function_metadata_;
   /*! \brief name map */
   std::unordered_map<std::string, size_t> name_map_;
   /*! \brief compile engine */
   CompileEngine compile_engine_;
+  /*! \brief main function name */
+  const String kMainFuncStr = "main_func";

Review comment:
       Cool! I like _tvm_<mod_name>_run. 
   
   @giuseros any objection?

##########
File path: src/relay/backend/graph_executor_codegen.cc
##########
@@ -551,10 +713,14 @@ class GraphExecutorCodegen : public 
backend::MemoizedExprTranslator<std::vector<
   Map<Expr, Array<IntegerArray>> storage_device_map_;
   /*! \brief lowered funcs */
   std::unordered_map<std::string, IRModule> lowered_funcs_;
+  /*! \brief lowered funcs */
+  Map<String, FunctionInfo> function_metadata_;
   /*! \brief name map */
   std::unordered_map<std::string, size_t> name_map_;
   /*! \brief compile engine */
   CompileEngine compile_engine_;
+  /*! \brief main function name */
+  const String kMainFuncStr = "main_func";

Review comment:
       Cool! I like \_tvm\_<mod_name>_run. 
   
   @giuseros any objection?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to