mbrookhart commented on a change in pull request #8007:
URL: https://github.com/apache/tvm/pull/8007#discussion_r629558634



##########
File path: tests/python/frontend/onnx/test_forward.py
##########
@@ -4217,6 +4228,8 @@ def verify_cumsum(indata, axis, exclusive=0, reverse=0, 
type="float32"):
     "test_maxpool_with_argmax_2d_precomputed_strides/",
     "test_maxunpool_export_with_output_shape/",
     "test_mvn/",
+    # For QLinearConv tests in ONNX, scale and zero_point input are 
placeholders,
+    # but qnn.conv2d requires scale and zero_point input to be scalar

Review comment:
       Can you explain this comment more?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to