areusch commented on a change in pull request #8014:
URL: https://github.com/apache/tvm/pull/8014#discussion_r631909163
##########
File path: python/tvm/micro/model_library_format.py
##########
@@ -55,17 +55,19 @@ def _populate_codegen_dir(mod, codegen_dir: str):
mod_indices = {"lib": 0, "src": 0}
host_codegen_dir = os.path.join(codegen_dir, "host")
+ lib_name = f"{model_name}_lib" if model_name else "lib"
+
for dso_mod in dso_modules:
if dso_mod.type_key == "c":
index = mod_indices["src"]
mod_indices["src"] += 1
parent_dir = os.path.join(host_codegen_dir, "src")
- file_name = os.path.join(parent_dir, f"lib{index}.c")
+ file_name = os.path.join(parent_dir, f"{lib_name}{index}.c")
Review comment:
yeah i like this idea, but we should bump the
[version](https://github.com/apache/tvm/blob/main/python/tvm/micro/model_library_format.py#L225)
in the metadata to indicate a format change. since MLF is new and not used
much yet, i don't think this is consequential, and would rather get in the
practice of doing this now rather than trying to judge some more confusing
criteria later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
