mehrdadh commented on a change in pull request #8144:
URL: https://github.com/apache/tvm/pull/8144#discussion_r644145200
##########
File path: docker/bash.sh
##########
@@ -46,6 +46,16 @@ if [[ "$1" == "--net=host" ]]; then
shift 1
fi
+# Mount external directory to the docker
+CI_DOCKER_MOUNT_DIR=( )
+CI_DOCKER_MOUNT_CMD=""
+if [[ "$1" == "--mount" ]]; then
+ shift 1
+ CI_DOCKER_MOUNT_DIR+="$1"
+ shift 1
+ CI_DOCKER_MOUNT_CMD="--mount
type=bind,source=${CI_DOCKER_MOUNT_DIR},target=${CI_DOCKER_MOUNT_DIR}"
Review comment:
changed the `CI_DOCKER_MOUNT_CMD `.
Regarding to -v vs mound, docker website recommends using mount option since
it has a better readable syntax and easier to use. But I don't have a
preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
