electriclilies commented on a change in pull request #8110:
URL: https://github.com/apache/tvm/pull/8110#discussion_r647713947



##########
File path: src/driver/driver_api.cc
##########
@@ -109,6 +109,51 @@ void GetBinds(const Array<te::Tensor>& args, bool compact,
   }
 }
 
+void GetBinds(const Array<ObjectRef>& args, bool compact,

Review comment:
       Array<te::Tensor> is not a subtype of Array<ObjectRef>, so C++ can't 
upcast the args and just call the other one. So I won't remove the signature, 
but I'll have the one that has Array<te::Tensor> as args upcast each element 
ObjectRef, then call the other GetBinds




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to