AndrewZhaoLuo commented on a change in pull request #8069:
URL: https://github.com/apache/tvm/pull/8069#discussion_r648596936



##########
File path: python/tvm/relay/transform/transform.py
##########
@@ -1199,3 +1198,20 @@ def FakeQuantizationToInteger():
         The registered SimplifyExpr pass.
     """
     return _ffi_api.FakeQuantizationToInteger()
+
+
+def AMPRewrite():

Review comment:
       I disagree. All the passes have names which are verbs which describe 
what they do while `AMP` is a noun. Maybe `AutoCast` would be better but it 
doesn't capture the mixed precision nature.
   
   Maybe `ToMixedPrecision` would be a better name?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to