AndrewZhaoLuo commented on a change in pull request #8069: URL: https://github.com/apache/tvm/pull/8069#discussion_r651430536
########## File path: src/relay/transforms/fp32_to_fp16.h ########## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file fp32_to_fp16.h + * \brief Utilities and common types used for FP32->FP16 pass. + */ +#ifndef TVM_RELAY_TRANSFORMS_FP32_TO_FP16_H_ +#define TVM_RELAY_TRANSFORMS_FP32_TO_FP16_H_ + +#include <tvm/ir/op.h> +#include <tvm/relay/expr.h> +#include <tvm/relay/function.h> + +#include <string> +#include <unordered_map> +#include <unordered_set> +#include <utility> +#include <vector> + +namespace tvm { +namespace relay { + +struct FP16OpDType { + DataType accumulation_dtype; + DataType output_dtype; +}; + +// GREEN colored ops should always be done in FP16 due to the speed and memory savings +// GRAY colored ops can be done in FP16 but don't have speedups to justify a dedicated cast. +// RED colored ops should not be done in FP16 due to numerical reasons. +enum FP16ConversionCategory { RED, GRAY, GREEN }; Review comment: I've implemented the suggestions listed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
