junrushao1994 edited a comment on pull request #5: URL: https://github.com/apache/tvm-rfcs/pull/5#issuecomment-875121662
@tkonolige thanks for the review! > The biggest one I can think of is the fact that we will have to rewrite all our existing schedules to take advantage of the new infrastructure. Given in most of the time we use sketch generation (in Ansor's terminology) to generate schedules automatically, we can just remove most of the schedules written in TE. Alternatively, we do need to rewrite all of the Ansor's sketch rules, including (defined in `src/auto_scheduler/search_policy/sketch_policy_rules.h`): - Always-Inline - Multi-Level-Tiling - Multi-Level-Tiling-with-Fusion - Add-Cache-Read - Add-Cache-Write - Add-RFactor - Simplify-Compute-with-Const-Tensor - Cross-Thread-Reduction - Special-Compute-Location > Also, will tuning be slower if we allow users to define their own search rules? The search rule is only executed once to obtain the search space before we explore it, and it is usually fairly fast (within a second), so If we only customize our own search rule (i.e. sketch rule in Ansor, schedule rule in meta schedule), we won't observe performance degradation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
