areusch commented on pull request #8: URL: https://github.com/apache/tvm-rfcs/pull/8#issuecomment-886973596
Thanks @Mousius @gromero for your comments. updated the RFC to reflect accurately on PoC now that it seems to be passing regression. Please take another look so we can merge this and proceed forward with Project API. @gromero some follow-ups on your comments: > On generate_project method, and considering TVMC, my only comment is that it should allow a project creation based also on MLF .tar, instead of only a "live" executor. I agree; let's merge additional logic in `project.py` to do this as follow-on to this impl. > On build method I just think it should be a way to force a rebuild in the same project dir (i.e. even if build dir exists) I believe that is the functionality now. Did you see something different? > On transport, please consider my comments inline, specially the bit a about the speed regression. Replied to your comments; I believe the speed issue is not a problem now. > Also, if possible, please consider the comments I've posted to the draft code also (apache/tvm#8380) Will take a look at these now that PoC is passing > Finally, I confirm that the fixes for MAX_ defines are ok (no build error) and the per board configs are kicking in correctly. I reworked the way these are done since posting the PoC--now `prj.conf` is generated from `microtvm_api_server.py` so we can have a single combined `template_project` and the `prj.conf` can be situation-specific. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
