denise-k commented on pull request #8784: URL: https://github.com/apache/tvm/pull/8784#issuecomment-901266341
@Lunderberg thanks for opening this PR. In my opinion, it's an overall net positive to have the Vulkan tests in CI. However, until we have good data on how much run time Vulkan GPU vs. Swiftshader would add to the CI jobs, it's difficult to actually assess the impacts or vote on a decision. For instance, if we enable Vulkan tests on the GPU and it doubles CI runtimes, we'd definitely want to assess all our options to minimize impact here, including using Swiftshader, minimizing the test cases, etc. If the test cases take 5 minutes, I'd personally have no issue landing it. But if it takes 30 mins? 1 hour? that's a bit more of a grey area for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
