[GitHub] [tvm] Mousius commented on pull request #8802: Add LowerTEPass, and convert calls to LowerTE to application of LowerTEPass

[GitBox]

Mousius commented on pull request #8802:
URL: https://github.com/apache/tvm/pull/8802#issuecomment-903111720


   Hi @electriclilies,
   
   I just took a look at your branch using `Target` and I think the runtime 
issues stem from `src/relay/backend/build_module.cc`:
   ```
   Map<String, IRModule> GetIRModule() {
       return CallFunc<Map<String, IRModule>>("get_irmodule", nullptr);
   }
   ```
   Then some further pieces which use strings rather than targets:
   ```
     if (lowered_funcs.find("ext_dev") != lowered_funcs.end()) {
         lowered_funcs.Set("ext_dev", IRModule());
   ```
   And:
   ```
         if (lowered_funcs.find(target_host->str()) == lowered_funcs.end()) {
           lowered_funcs.Set(target_host->str(), IRModule(Map<GlobalVar, 
BaseFunc>({})));
          }
         lowered_funcs[target_host->str()]->Add(
             GlobalVar(::tvm::runtime::symbol::tvm_lookup_linked_param), prim);
        }
   ```
   
   Changing these and applying your fixes from this branch appears to let me 
run the AOT tests at least.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org