tqchen commented on pull request #23: URL: https://github.com/apache/tvm-rfcs/pull/23#issuecomment-903112540
Thank you @manupa-arm for the proposal. What you described is closest to the "tag" field of the storage scope, which we put as part of the pointer and associate with most of the storage. I think it would be great to think in terms of this direction. Specifically, when we have a clear distinction of memory types, "sram", "shared_memory", "texture". We will use the special memory tag to indicate the type of such kind of memory. The proposed pinned memory field, however, have multiple of such candidates. In my understanding tries to serve as an additional hints to follow up passes. If the intended use is multiple candidate hints, then the tag is perhaps no longer approperiate because it is used to indicate one kind of special memory that we place the data to. In that case, I think it could be closer to an additional annotation field https://github.com/apache/tvm/blob/main/include/tvm/tir/stmt.h#L817 that stores additional attribute hints about the particular node. This would also help reduce the possible indirection introduced by AttrStmt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
