mbs-octoml commented on pull request #8795:
URL: https://github.com/apache/tvm/pull/8795#issuecomment-908499201
To be clear LGTM for this one modulo all the existing comments, and looks
pretty good out to P5. Just:
1) a suggestion to move some files to follow existing conventions,
2) put some type annots for relay types if it's not hard to do so,
3) I expect by P4 we'l have the relay_to_tir extension point we want in
place so shouldn't need to replicate the lower te pass with it's dependency on
the old compile engine.
For my own education I'd like to understand the custom te + custom
scheduling combination being used here, some octoml folks are meeting Tue AM so
I'm going to demand an explanation then!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
