areusch commented on a change in pull request #8940:
URL: https://github.com/apache/tvm/pull/8940#discussion_r703527961
##########
File path: apps/microtvm/reference-vm/README.md
##########
@@ -72,20 +72,20 @@ For example:
$ ./base-box-tool.py --provider virtualbox build zephyr
```
-2. **Run** release tests for each platform:
+2. **Run** release tests for each microTVM device:
Review comment:
as this is in context of a base box release test, i think this should
use the same language as we use in tests/micro/zephyr/test_zephyr.py
##########
File path: apps/microtvm/arduino/template_project/microtvm_api_server.py
##########
@@ -43,6 +43,19 @@
IS_TEMPLATE = not (API_SERVER_DIR / MODEL_LIBRARY_FORMAT_RELPATH).exists()
+# Maps a short, identifying microtvm device string to (target, arduino_board).
+MICRO_DEVICES = {
Review comment:
i might be a bit dense here but where is this used in
microtvm_api_server.py? prefer to avoid complicating that file except when
necessary
##########
File path: tests/micro/arduino/conftest.py
##########
@@ -48,13 +35,23 @@
).resolve()
+def arduino_micro_devices() -> dict:
+ sys.path.insert(0, str(TEMPLATE_PROJECT_DIR))
+ try:
+ import microtvm_api_server
+ finally:
+ sys.path.pop(0)
+
+ return microtvm_api_server.MICRO_DEVICES
Review comment:
i don't favor doing this. can we use the ProjectOption/choices
infrastructure if we want to forward this data? this preserves the API boundary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
