csullivan commented on a change in pull request #8960: URL: https://github.com/apache/tvm/pull/8960#discussion_r704840247
########## File path: tests/python/contrib/test_hexagon/test_conv2d_blocked.py ########## @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import sys + +import tvm +from tvm import te +from tvm import topi +from tvm.topi import testing +from .infrastructure import ceildiv +from .infrastructure import get_packed_layout +from .infrastructure import build_and_run + +import numpy as np +import pytest + + +def conv2d_logical( + shape_nhwc, + shape_kcrs, Review comment: If you would like I can convert the conv2d definitions over to OIHW for consistency. I actually did in anticipation of someone making this comment, but I reverted it because I became confused when reading the schedule. :) Too many axes like `Oi`, `Ii`, `Iii`, `H_input`, `H_filter`, `W_inp`, `W_filt` floating around. That said, I don't have strong feelings on it either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
