mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r708732062
########## File path: include/tvm/runtime/logging.h ########## @@ -395,8 +399,8 @@ class LogMessageVoidify { inline bool DebugLoggingEnabled() { static int state = 0; if (state == 0) { - if (auto var = std::getenv("TVM_LOG_DEBUG")) { - if (std::string(var) == "1") { + if (const char* var = std::getenv("TVM_LOG_DEBUG")) { + if (var[0] == '1') { Review comment: This was a lazy way to allow "1" or "1;...." to enable. I made it more specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org