areusch commented on a change in pull request #8990:
URL: https://github.com/apache/tvm/pull/8990#discussion_r709432323
##########
File path: apps/microtvm/reference-vm/zephyr/base-box/base_box_test.sh
##########
@@ -37,3 +37,5 @@ if [ $board == "stm32f746xx" ]; then
else
pytest tests/micro/zephyr/test_zephyr_aot.py --zephyr-board=${board}
fi
+
+pytest tests/micro/zephyr/test_zephyr_armv7m.py --zephyr-board=${board}
Review comment:
it's tempting to inline `read_and_pad`, which should get inlined by the
compiler at codegen time. CMSIS 5 is [under ASF
2.0](https://github.com/ARM-software/CMSIS_5/blob/develop/LICENSE.txt). the
tricky thing is that there are quite a lot of header dependencies designed to
support a variety of toolchains. it would be nice to preserve support for those.
given that, i'm tempted to opt for downloading CMSIS to the temporary
directory. we will likely need to come up with a solution for this more broadly
to work with CMSIS-NN as well cc @ashutosh-arm @u99127 @manupa-arm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
