mehrdadh commented on a change in pull request #9274:
URL: https://github.com/apache/tvm/pull/9274#discussion_r734892831
##########
File path: apps/microtvm/arduino/template_project/microtvm_api_server.py
##########
@@ -275,7 +286,25 @@ def _find_modified_include_path(self, project_dir,
file_path, include_path):
# It's probably a standard C/C++ header
return include_path
+ def _get_platform_version(self, arduino_cli_path: str) -> float:
+ version_output = subprocess.check_output([arduino_cli_path,
"version"], encoding="utf-8")
+ version_output = (
+ version_output.replace("\n", "").replace("\r", "").replace(":",
"").lower().split(" ")
Review comment:
thanks for the review. The format is like
`major_version:minor_version:patch`. I will add comment and change it to use
regex in the following PR which is waiting for this:
https://github.com/apache/tvm/pull/9309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
