adstraw commented on a change in pull request #9525:
URL: https://github.com/apache/tvm/pull/9525#discussion_r751667185



##########
File path: src/runtime/hexagon/hexagon/hexagon_common.cc
##########
@@ -57,7 +57,10 @@ void HexagonLookupLinkedParam(TVMArgs args, TVMRetValue* rv) 
{
   std::vector<int64_t> shape_vec{template_tensor->shape,
                                  template_tensor->shape + 
template_tensor->ndim};
 
-  auto* param_buffer = new HexagonBuffer(static_cast<void*>(opaque_handle));
+  // TODO: get nbytes from shape/dtype
+  size_t nbytes = 2048;

Review comment:
       Right, wasn't quite sure how to calculate the size so I left a TODO 
there.  Need to do some calculation on shape and dtype.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to