wrongtest commented on a change in pull request #9522:
URL: https://github.com/apache/tvm/pull/9522#discussion_r753647190



##########
File path: include/tvm/relay/executor.h
##########
@@ -159,9 +159,6 @@ class Executor : public ObjectRef {
  */
 class ExecutorRegEntry {
  public:
-  /*! \brief Set name of the Executor to be the same as registry if it is 
empty */
-  inline ExecutorRegEntry& set_name();

Review comment:
       Guess that's some codes forget to be cleaned by authors. Also 
`RegisterOrGet(const String& name)` in current attr registry mechanism 
automatically set entry's name already. It should be not necessary to add a 
zero param `set_name()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to