gromero commented on a change in pull request #9663:
URL: https://github.com/apache/tvm/pull/9663#discussion_r764406816
##########
File path: tests/micro/common/test_tvmc.py
##########
@@ -118,17 +126,25 @@ def test_tvmc_model_build_only(board):
["micro", "build", project_dir, platform, "--project-option",
f"{platform}_board={board}"]
)
assert cmd_result == 0, "tvmc micro failed in step: build"
+ shutil.rmtree(output_dir)
@pytest.mark.requires_hardware
@tvm.testing.requires_micro
-def test_tvmc_model_run(board):
[email protected](
+ "output_dir,",
+ [pathlib.Path("./tvmc_relative_path_test"),
pathlib.Path(tempfile.mkdtemp())],
+)
+def test_tvmc_model_run(board, output_dir):
target, platform = _get_target_and_platform(board)
+ if not os.path.isabs(output_dir):
Review comment:
Same here: it defeats the main purpose of testing relative paths as
mentioned above. It needs to get fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
