mbs-octoml commented on a change in pull request #9669:
URL: https://github.com/apache/tvm/pull/9669#discussion_r767960497
##########
File path: tests/python/relay/test_vm.py
##########
@@ -1112,6 +1112,20 @@ def test_multi_targets():
tvm.testing.assert_allclose(actual_result.numpy(), expected_result)
+def test_dialect_rewriter():
+ """Tests dialect rewriter for tuple node."""
+
+ x = relay.var("x", shape=(3,), dtype="int32")
+ y = relay.take(x, relay.const(0))
+ z = relay.const(1)
+
+ f = relay.Function([x], relay.stack((z, y), axis=0))
+ mod = IRModule.from_expr(f)
+
+ compiler = VMCompiler()
+ compiler.optimize(mod, "llvm")
Review comment:
nit: thanks for the unit test. Since there's no assertion, please
comment that this tests for an ICHECK failure for ill-formed IL with let-bound
constants. The test name can similarly describe what is being testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
