mbs-octoml commented on a change in pull request #9693:
URL: https://github.com/apache/tvm/pull/9693#discussion_r767974458
##########
File path: src/relay/op/call/call.cc
##########
@@ -63,23 +63,23 @@ bool CallLoweredRel(const Array<Type>& types, int
num_inputs, const Attrs& attrs
const Op& CallLoweredOp() { return Op::Get("call_lowered"); }
-Expr CallLowered(Expr func, Array<Expr> inputs, Attrs attrs, Array<Type>
type_args, Span span) {
- // Right now, call_lowered only supports func being a global var pointing to
the lowered
- // function.
- ICHECK(func.as<GlobalVarNode>())
- << "Function to call should be GlobalVarNode, but got:" << std::endl
- << PrettyPrint(func);
- ICHECK(attrs.as<CallLoweredAttrs>())
- << "Expected attributes to be CallLoweredAttrs, but got " <<
attrs->GetTypeKey();
- return Call(CallLoweredOp(), {std::move(func), Tuple(std::move(inputs))},
std::move(attrs),
- std::move(type_args), std::move(span));
+Call CallLowered(GlobalVar lowered_func, Array<Expr> args, CallLoweredAttrs
call_lowered_attrs,
+ Span span) {
+ auto attrs = make_object<CallLoweredAttrs>(std::move(call_lowered_attrs));
Review comment:
make_object constructs the ObjectPtr<CallLoweredAttrs>. It takes a copy
of call_lowered_attrs, but since its currently only field is itself an object
ref the move into that ObjectPtr is worthwhile.
This would all make more sense if CallLoweredAttrs was an ObjectRef to a
CallLoweredAttrsNode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
