junrushao1994 commented on a change in pull request #9729:
URL: https://github.com/apache/tvm/pull/9729#discussion_r768036732
##########
File path: include/tvm/ir/module.h
##########
@@ -57,6 +57,8 @@ class IRModuleNode : public Object {
Map<GlobalVar, BaseFunc> functions;
/*! \brief A map from global type vars to ADT type data. */
Map<GlobalTypeVar, TypeData> type_definitions;
+ /*! \brief The external module containing the external functions used by
this module. */
+ Array<runtime::Module> external_mods;
Review comment:
I don't think we are directly saying "no" here. To better organize our
discussion:
1. It mixes compile-time IR and the runtime thing - usually it's done by a
linker instead.
2. There exists better alternatives to use metadata module.
Cody mainly wanted to introduce some history in the design rationale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
