kparzysz-quic commented on a change in pull request #10710:
URL: https://github.com/apache/tvm/pull/10710#discussion_r833527843
##########
File path: src/target/llvm/codegen_hexagon.cc
##########
@@ -69,6 +69,9 @@ class CodeGenHexagon final : public CodeGenLLVM {
llvm::Module* GetModulePtr() const { return module_.get(); }
protected:
+ void CreatePrintf(const std::string& format,
+ const llvm::ArrayRef<llvm::Value*>& format_args) final;
Review comment:
`llvm::ArrayRef` is meant to be passed by value, sorry, I should have
been clearer about it (it's an array "view", like `std::string_view`). This
can be fixed in a different PR though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
