csullivan commented on code in PR #11025:
URL: https://github.com/apache/tvm/pull/11025#discussion_r852197218
##########
apps/hexagon_launcher/cmake/hexagon/CMakeLists.txt:
##########
@@ -79,15 +79,16 @@ ExternalProject_Add(static_hexagon_tvm_runtime
SOURCE_DIR "${TVM_SOURCE_DIR}"
BUILD_COMMAND $(MAKE) runtime
CMAKE_ARGS
+ "-DBUILD_STATIC_RUNTIME=ON"
"-DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}"
"-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}"
- "-DUSE_HEXAGON_ARCH=${USE_HEXAGON_ARCH}"
"-DCMAKE_CXX_STANDARD=14"
+ "-DUSE_HEXAGON_ARCH=${USE_HEXAGON_ARCH}"
+ "-DUSE_HEXAGON=ON"
Review Comment:
nit: Place USE_HEXAGON=ON before other hexagon cmake variable definitions
##########
CMakeLists.txt:
##########
@@ -40,8 +40,8 @@ tvm_option(USE_SPIRV_KHR_INTEGER_DOT_PRODUCT "whether enable
SPIRV_KHR_DOT_PRODU
tvm_option(USE_METAL "Build with Metal" OFF)
tvm_option(USE_ROCM "Build with ROCM" OFF)
tvm_option(ROCM_PATH "The path to rocm" /opt/rocm)
-tvm_option(USE_HEXAGON_DEVICE "Build with Hexagon device support in TVM
runtime" OFF)
-tvm_option(USE_HEXAGON_SDK "Path to the Hexagon SDK root (required for Hexagon
support in TVM runtime or for building TVM runtime for Hexagon)" /path/to/sdk)
+tvm_option(USE_HEXAGON "Build with Hexagon support" OFF)
Review Comment:
Some TVM config options provide [ON|OFF|PATH_TO_SDK], with ON indicating to
search for the SDK in common directories and fail otherwise.
##########
apps/hexagon_api/CMakeLists.txt:
##########
@@ -35,6 +35,7 @@ ExternalProject_Add(x86_tvm_runtime_rpc
"-DUSE_LIBBACKTRACE=OFF"
Review Comment:
I didn't catch the motivation on introduction of `hexagon_api` earlier this
year, but to add to the backlog it would be nice if the `hexagon_api` was built
automatically as part of a USE_HEXAGON=ON build. It's easy for users to forget
to recompile the hexagon_api after making changes and only rebuilding tvm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
